search

benbaran / adal-angular4

Angular 4/5/6/7 ADAL Wrapper
MIT License
87 stars 106 forks source link

Adal Angular 1.0.15 to 1.0.17 #91

Closed kameelyan closed 5 years ago

kameelyan commented 6 years ago

I noticed that this wrapper forces version 1.0.15 for adal-angular, are there any plans to update to 1.0.17?

rahulraibit commented 5 years ago

I don't know why this library is still using 1.0.15 version of adal angular. Please update to 1.0.17. This will solve acquire token issue during first time login because I have noticed in 1.0.17 version we have options to pass loadFrameTimeout which is not available for 1.0.15. This frameTimeout issue which is keep coming to many user because default LOADFRAME_TIMEOUT: '6000' ms

chase-swanson commented 5 years ago

This is why, but I am not sure which open issues are the ones addressing

47

leonixyz commented 5 years ago

The reason is that with the release of adal-angular 1.0.16 Microsoft changed the library API, but the version was still released as a "patch" (see comment)

michaeltarleton commented 5 years ago

(bump) Any plans to upgrade the adal-angular dependency?

benbaran commented 5 years ago

I would love to, but the code doesn’t work with newer versions. I assume it’s a bug in my code, but I don’t have time at the moment to track it down.

Sent from my iPhone

On Nov 29, 2018, at 9:55 AM, michaeltarleton notifications@github.com wrote:

(bump) Any plans to upgrade the adal-angular dependency?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

geerzo commented 5 years ago

I found a fix I believe. I've committed a change (5e97bb57622dcb786f1f1da10674fa7c2409afaa) that I believe fixes this issue and allows us to use more recent adal.js libraries.

geerzo commented 5 years ago

This is now fixed as part of the 4.x release.