fix issue & upgrade to angular/rxjs 6

benbaran / msal-angular

Angular MSAL Wrapper Module

MIT License

16 stars 16 forks source link

fix issue & upgrade to angular/rxjs 6 #11

Closed Marcelh1983 closed 6 years ago

Marcelh1983 commented 6 years ago

Hi,

I tested the 4 issues and think they are all solved in this pull request.

Breaking changes:

signUpSignInPolicy and tenant are replaced by authority

before:

MsalModule.forRoot({ signUpSignInPolicy: 'B2C_1_SiUpIn', tenant: 'xxx.onmicrosoft.com' ...

after:

MsalModule.forRoot({ authority: 'https://login.microsoftonline.com/tfp/xxx.onmicrosoft.com/B2C_1_SiUpIn',...

= rxjs 6.0

RobCannon commented 6 years ago

Is this PR going to get approved soon? I was unable to get this package to work with Angular 6 and I hope this will address those issues.

benbaran commented 6 years ago

Merged : )

Sent from my iPhone

On May 30, 2018, at 9:35 PM, Rob Cannon notifications@github.com wrote:

Is this PR going to get approved soon? I was unable to get this package to work with Angular 6 and I hope this will address those issues.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.