search

benbarnett / jquery-animate-enhanced

Extend $.animate() to detect CSS transitions for Webkit, Mozilla, IE>=10 and Opera and convert animations automatically.
http://playground.benbarnett.net/jquery-animate-enhanced/
MIT License
1.39k stars 196 forks source link

Delay isn't working correctly #130

Closed aaerox closed 10 years ago

aaerox commented 11 years ago

The animate function as is will never queue up, instead just performing all the animation immediately using an each call.

I think

return this[ optall.queue === true ? 'queue' : 'each' ](function() {

should be changed to

return this[ optall.queue === false? 'each' : 'queue' ](function() {

Also, when this is done the animations don't get dequeued once they're finished. I think this is due to the "optall.complete.apply(elements, arguments);" call passing the elements as a jquery object, rather than one at a time as dom elements.

aaerox commented 11 years ago

Also, for the original animate call at the end of the animate function where you call to animate dom properties that aren't handled by your plugin, shouldn't queue always be set to false? Otherwise you're waiting for callbackQueue to be reduced to dequeue, which won't happen until you yield the queue.

benbarnett commented 10 years ago

Duplicate #61