benbarnett / jquery-animate-enhanced

Extend $.animate() to detect CSS transitions for Webkit, Mozilla, IE>=10 and Opera and convert animations automatically.
http://playground.benbarnett.net/jquery-animate-enhanced/
MIT License
1.39k stars 196 forks source link

slidetoggle doesn't use css #144

Closed intergalactic-overlords closed 10 years ago

intergalactic-overlords commented 10 years ago

In the readme it says that slideToggle is supported, but when I implement it, it just uses regular jQuery transition, not css3. Does it need some extra parameters, or am I doing something wrong?

I use jquery version 1.4.4 and jquery animate enhanced 1.0.7

my code:

$(context).find('.region-navigation > .block-menu-block').each(function() {
  var $this = $(this);
  var $content = $this.children('.content').first();

  $content.hide(0, function() {
    $content.addClass('hidden');
    $content.css('display', '');
  });

  $this.children('.menu-title').click(function() {
    if ($content.hasClass('hidden')) {
      $content.hide(0, function() {
        $content.removeClass('hidden');
        $content.slideToggle(300, function() {
          $content.css('display', '');
        });
      });
    } else {
      $content.slideToggle(300, function() {
        $content.addClass('hidden');
        $content.css('display', '');
      });
    }
  });
});
alexey-sh commented 10 years ago

Same here:

<div class="target">
            Content to slide
</div>
<button id="start">Run test</button>
<script>
$('button#start').click(function() {
                    button = $(this).attr('disabled', 'disabled');
                    $('.target').slideToggle(1000, function() {
                            $('.target').slideToggle(1000, function() {
                                    button.removeAttr('disabled');
                            });
                    });
            });
</script>

with jquery-1.10.2 and jquery.animate-enhanced plugin v1.08 in Chrome 32

benbarnett commented 10 years ago

Correct, sorry if docs are misleading but this is intentional