benbasson / imagetoolbar

Firefox Extension - Image Toolbar is a clone of one of Internet Explorer's features and provides quick and easy access to a handful of image functions in a highly customisable way.
http://www.basson.at/firefox-addons/imagetoolbar
Other
9 stars 4 forks source link

Compatibility issues with Pale Moon #9

Closed rdegraaff closed 9 years ago

rdegraaff commented 9 years ago

I'm using Pale Moon x64, which is based on Firefox. Since their latest version (25.2.0) images called from img tags are not rendered, when Image Toolbar 0.6.14 is installed. The add-on worked fine with Pale Moon 25.1.0. Newer versions of the add-on are not installable (incompatible "Firefox" version).

Pale Moon's main dev pointed me to these changes as the possible cause / solution. Is there anything you could do to fix the incompatibility? I've been happily using your add-on for some years.

z235 commented 9 years ago

Another Pale Moon user here.

Hello Ben, adding support for PM would be great indeed. You seem like a cool guy, so I hope you are willing to make this compatible to our little browser project... :beers:

gdighton commented 9 years ago

Also a Pale Moon user, and experienced the same problem (glad to see I'm not the only one!)

emicom commented 9 years ago

The same with me. I've use Image Toolbar for years now and (honestly) is my favorite add-on. But with PM 25.2 is not possible to to install IT 0.6.16 or 0.6.15. Pls Ben, can you help and make IT for PM users work? :)

emicom commented 9 years ago

Yeah, I think I found a solution. In the file {A4732521-77D9-447E-A557-B279AC923F06}.xpi (it is IT xpi located in \Application Data\Moonchild Productions\Pale Moon\Profiles\) chrome\imagetoolbar\content\imagetoolbar.xml on entry " binding id" (I am talking for ver. 0.6.15) must be - it happen twice. Then (for compatible issue of PM) in the xpi install.rdf the must change the old entry to: em:minVersion25.0/em:minVersion em:maxVersion27.0.*/em:maxVersion Hope it temporarily helps. Ben, can you please make IT compatible with Pale Moon 25+?:)

Trapperman commented 9 years ago

^^^ Ditto on everything above x100

I've become so dependent on Image Toolbar that I feel lost without it now. PLEASE Ben, make it compatible with Pale Moon v25.2++

masoko182 commented 9 years ago

I'm another Pale Moon user, please update your awesome extension so it can be compatible. Thanks in advance!

sobcz commented 9 years ago

You can get my fixed version from http://1drv.ms/1GFlyFu, file image_toolbar-0.6.16-pmfix.xpi. I sent pull request some time ago, but it seems that author is busy. Then I kind of forgot about it (it worked here, so... ;).

Changes can be seen in pull request #10, plus there's changed name to "Image Toolbar (unofficial Pale Moon hotfix)". But don't trust me, check it yourself (hint: xpi is renamed zip).

masoko182 commented 9 years ago

Thanx! It works like a charm

2015-03-14 19:54 GMT-03:00 Sob notifications@github.com:

You can get my fixed version from http://1drv.ms/1GFlyFu, file image_toolbar-0.6.16-pmfix.xpi. I sent pull request some time ago, but it seems that author is busy. Then I kind of forgot about it (it worked here, so... ;).

Changes can be seen in pull request #10 https://github.com/benbasson/imagetoolbar/pull/10, plus there's changed name to "Image Toolbar (unofficial Pale Moon hotfix)". But don't trust me, check it yourself (hint: xpi is renamed zip).

— Reply to this email directly or view it on GitHub https://github.com/benbasson/imagetoolbar/issues/9#issuecomment-80751906 .

benbasson commented 9 years ago

Hi everyone. Sorry, I have no plans to add support for Pale Moon (as I do not use it and do not want to download loads of Firefox / Mozilla forks to test my add-ons with), but I will keep maintaining the addon-on for use with Firefox.

If someone wants to maintain a Pale Moon fork of Image Toolbar on GitHub I'm more than happy to work with them on that and am happy to share new code / features - I just don't want the extra testing / compatibility burden.

benbasson commented 9 years ago

I'd be happy for it to be called "Image Toolbar for Pale Moon" or similar. Please credit me as the original author + retain licence headers while adding anyone necessary as additional authors.