search

benbender / x1c6-hackintosh

READMEs, Clover, OpenCore configurations, patches, and notes for the Thinkpad X1 Carbon 6th Gen 2018 Hackintosh
https://tylernguyen.github.io/x1c6-hackintosh/
MIT License
26 stars 2 forks source link

Incorrect BAT remaining time. #1

Closed tylernguyen closed 3 years ago

tylernguyen commented 3 years ago

Per our discussion, with the new battery patch: energy and info readings are correct. However, remaining time seems to be absurdly off.

EDIT: Machine: X1C6 20KH*

benbender commented 3 years ago

Nope, there isnt. There is "battery conservation" though, but it should only control the loading behaviour afaik. I think its more like a thing/problem by osx or virtualsmc as of BATX. Wouldn't be surprised if its simply OSX.

buyddy commented 3 years ago
Screen Shot 2020-11-06 at 2 25 23 PM

It is quite strange. The numbers from reading is actually correct but the percentage is simply off. Is it a MacOS thing? Is the percentage calculated by the Application?

buyddy commented 3 years ago

@benbender It seems that 20:00 came back after updating to quick poll. I was on AC, unplugged it, and then it is showing 20:00. Not updating.

benbender commented 3 years ago

I think the percentage offset isn't an ACPI-problem. As you said I can confirm, the readings seem to be correct. For the incorrect runtime, it needs investigation as I said. If it doesn't update after quickpoll is enabled, that's quite strange. If it happens, try to replug the ac as it should trigger a power-event which should VSMC pull the static data from ACPI again.

buyddy commented 3 years ago

I think the percentage offset isn't an ACPI-problem. As you said I can confirm, the readings seem to be correct. For the incorrect runtime, it needs investigation as I said. If it doesn't update after quickpoll is enabled, that's quite strange. If it happens, try to replug the ac as it should trigger a power-event which should VSMC pull the static data from ACPI again.

I sleep the laptop and wake up the estimate is normal now.

benbender commented 3 years ago

For testing: You could try to comment both the CBSS()- and CBIS()-Method - this disables BIS (https://github.com/acidanthera/VirtualSMC/blob/master/Docs/Battery%20Information%20Supplement.md) maybe the problem is there as this feature is quite new and not widely adopted yet.

buyddy commented 3 years ago

Offset (0x68), BAPR, 16, // Percent / Charge Level Offset (0x6E), B1CC, 16, // ChargingCurrent B1CV, 16, // ChargingVoltage Offset (0x7E), B1AR, 16, // Average Rate Offset (0xA4), B1CY, 16, // _BIX[8] - Cycle Count Offset (0xC0), BARN, 184, // _BIX[0x11] - Serial Number - "XXXXXSSSYYY"

Two things that are interesting: BAPR & B1AR, so EC contains Percentage/Charge level and average rate? Does the battery monitor app read directly from that? Could it be that this is the source of error? Or if not reading from EC, could this be the missing piece?

buyddy commented 3 years ago

@benbender in BATX do you read these fields from EC or do you ignore those? I suspect 20 hour is related to B1AR being 0.

benbender commented 3 years ago

I'm reading both. Both are part of BIS. But that's only the first part: those values are read from ACPI by VirtualSMC which in turn provides various metrics via SMC-vars to OSX. I'm quite sure my values aren't the problem.

buyddy commented 3 years ago

Out of curiosity, does YogaSMC do anything in between? Previously the battery reading never had 20:00 issues. I am guessing it has something to do with either the new ssdt patch or YogaSMC.

benbender commented 3 years ago

Its the new ssdt-patch. As I said, I think its a race-condition with some device or the EC.

buyddy commented 3 years ago

For testing: You could try to comment both the CBSS()- and CBIS()-Method - this disables BIS (https://github.com/acidanthera/VirtualSMC/blob/master/Docs/Battery%20Information%20Supplement.md) maybe the problem is there as this feature is quite new and not widely adopted yet.

Just did that, so far seems to work just fine. Will see if 20:00 shows up again.

benbender commented 3 years ago

I've updated SSDT-BATX to revision 6 which incorporates fixes, makes the testing points we identified here configureable and expands technical-background-documentation. Give it a shot and report back: https://github.com/benbender/x1c6-hackintosh/blob/experimental/EFI/OC/dsl/SSDT-BATX.dsl

buyddy commented 3 years ago

There is another bug I think. When I have set the charging threshold, and plug in the AC, battery will show "Not charging" but it is in fact charging. This is the case with or without CBSS and CBIS. @benbender

buyddy commented 3 years ago
Screen Shot 2020-11-07 at 9 16 57 AM

Updated to your new dsl, still the same. But the battery is actually charging and once I pull off the AC, the battery will correctly show its increased level.

tylernguyen commented 3 years ago

There is another bug I think. When I have set the charging threshold, and plug in the AC, battery will show "Not charging" but it is in fact charging. This is the case with or without CBSS and CBIS. @benbender

Same issue here. The battery won't update its charge level until the charger is unplugged.

benbender commented 3 years ago

Did some testing and I didn't understand the issue as I did everything like on the original DSDT - until I remembered that I "killed" all Battery-notifies. I always thought they would be only relevant to the OS updating things and wouldn't be much for us as VirtualSMC follows a polling approach.

However, since I patched the notifies, it seems to resolve the update issue. Seems like the EC is somehow dependent on it. Which I find terrible as I wanted to have a solution without ACPI-patching... But however, please add the following patch, test and report:

            <dict>
                <key>Comment</key>
                <string>BATX: BAT0 to BATX</string>
                <key>Count</key>
                <integer>0</integer>
                <key>Enabled</key>
                <true/>
                <key>Find</key>
                <data>hkJBVDA=</data>
                <key>Limit</key>
                <integer>0</integer>
                <key>Mask</key>
                <data></data>
                <key>OemTableId</key>
                <data></data>
                <key>Replace</key>
                <data>hkJBVFg=</data>
                <key>ReplaceMask</key>
                <data></data>
                <key>Skip</key>
                <integer>0</integer>
                <key>TableLength</key>
                <integer>0</integer>
                <key>TableSignature</key>
                <data>RFNEVA==</data>
            </dict>
tylernguyen commented 3 years ago

@benbender

The system is unable to read battery status after adding that patch: "Battery status is 0%"

benbender commented 3 years ago

@tylernguyen Sounds very strange and unlikely. It only patches Notify (BAT0, XX) to Notify (BATX, XX) in DSDT. Does it really work without the patch?

buyddy commented 3 years ago

@tylernguyen Sounds very strange and unlikely. It only patches Notify (BAT0, XX) to Notify (BATX, XX) in DSDT. Does it really work without the patch?

The patch seems to work fine for me. I don't have yogasmc though, and I am using the most recent BATX from Ben.

benbender commented 3 years ago

@buyddy yeah 👍 - but as a remark: YogaSMC has nothing to do with this. I think you misunderstood the role of YogaSMC. Its primarily a listener kext which listens to ec-events and reacts with a user-space-app on them. It doesn't play much of a role in PM or battery or pretty much anything else.

benbender commented 3 years ago

Revision 7 has landed: https://github.com/benbender/x1c6-hackintosh/blob/experimental/EFI/OC/dsl/SSDT-BATX.dsl

buyddy commented 3 years ago

I just tested the new version, the battery remaining time has been "calculating" for 5 minutes now. This is abnormal.

buyddy commented 3 years ago

Plugged in, the charging estimation time is there. Plug out, battery remaining time show "Calculating" again forever.

benbender commented 3 years ago

A bit more context would be nice. Does it work besides the "calculating-problem"? Do you have checked for ACPI-errors (log show --last boot|grep AE_)? Anything I can work with? :)

buyddy commented 3 years ago

2020-11-11 12:54:23.565357-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.565357-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.565359-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [NTFY] 2020-11-11 12:54:23.565359-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [NTFY] 2020-11-11 12:54:23.565360-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2020-11-11 12:54:23.565361-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_ALREADY_EXISTS 2020-11-11 12:54:23.565363-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2020-11-11 12:54:23.565363-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-462) 2020-11-11 12:54:23.565364-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2020-11-11 12:54:23.565365-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2020-11-11 12:54:23.565366-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2020-11-11 12:54:23.565366-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2020-11-11 12:54:23.565368-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2020-11-11 12:54:23.565368-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2020-11-11 12:54:23.565401-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2020-11-11 12:54:23.565402-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_ALREADY_EXISTS, 2020-11-11 12:54:23.565404-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: _TB3) while loading table 2020-11-11 12:54:23.565404-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: _TB3) while loading table 2020-11-11 12:54:23.565406-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2020-11-11 12:54:23.565406-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2020-11-11 12:54:23.565437-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.565437-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.565439-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [SB.PCI0.RP09.UPSB.DSB2] 2020-11-11 12:54:23.565439-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [SB.PCI0.RP09.UPSB.DSB2] 2020-11-11 12:54:23.565441-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_NOT_FOUND 2020-11-11 12:54:23.565441-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_NOT_FOUND 2020-11-11 12:54:23.565443-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-292) 2020-11-11 12:54:23.565443-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/dswload-292) 2020-11-11 12:54:23.565444-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_NOT_FOUND, 2020-11-11 12:54:23.565444-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_NOT_FOUND, 2020-11-11 12:54:23.565445-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2020-11-11 12:54:23.565446-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) During name lookup/catalog 2020-11-11 12:54:23.565447-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2020-11-11 12:54:23.565448-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psobject-310) 2020-11-11 12:54:23.565488-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_NOT_FOUND, 2020-11-11 12:54:23.565489-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_NOT_FOUND, 2020-11-11 12:54:23.565491-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: _XHC2) while loading table 2020-11-11 12:54:23.565491-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (SSDT: _XHC2) while loading table 2020-11-11 12:54:23.565493-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2020-11-11 12:54:23.565493-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-319) 2020-11-11 12:54:23.566479-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.566480-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.566481-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2 table load failures, 28 successful 2020-11-11 12:54:23.566482-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2 table load failures, 28 successful 2020-11-11 12:54:23.566483-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342) 2020-11-11 12:54:23.566483-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/tbxfload-342)

Looks like I have ACPI errors from TB3 and XHC2. Anything from BATX that you can spot?

buyddy commented 3 years ago

Additional AE errors:

2020-11-11 12:54:23.641283-0600 0xa1 Default 0x0 0 0 kernel: (AppleAPIC) IOAPIC: Version 0x20 Vectors 64:111 2020-11-11 12:54:23.641356-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER, 2020-11-11 12:54:23.641357-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER, 2020-11-11 12:54:23.641359-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0 2020-11-11 12:54:23.641360-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0 2020-11-11 12:54:23.641362-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/evrgnini-340) 2020-11-11 12:54:23.641363-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/evrgnini-340) 2020-11-11 12:54:23.646608-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.646609-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Error: 2020-11-11 12:54:23.646610-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [U2OP] 2020-11-11 12:54:23.646611-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [U2OP] 2020-11-11 12:54:23.646612-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_NOT_FOUND 2020-11-11 12:54:23.646613-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Namespace lookup failure, AE_NOT_FOUND 2020-11-11 12:54:23.646614-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psargs-463) 2020-11-11 12:54:23.646615-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) (20160930/psargs-463) 2020-11-11 12:54:23.646617-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [HS03] @00023 #002D: 2020-11-11 12:54:23.646618-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) [HS03] @00023 #002D: 2020-11-11 12:54:23.646619-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2020-11-11 12:54:23.646620-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2020-11-11 12:54:23.646621-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) No Local Variables are initialized for method [HS03] 2020-11-11 12:54:23.646621-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) No Local Variables are initialized for method [HS03] 2020-11-11 12:54:23.646623-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2020-11-11 12:54:23.646623-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) 2020-11-11 12:54:23.646624-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) No Arguments are initialized for method [HS03]

velaar commented 3 years ago

Plugged in, the charging estimation time is there. Plug out, battery remaining time show "Calculating" again forever.

I can not replicate this. I have the time correct in 2-3 minutes after unplug. The rev 7 works very well for me.

image
buyddy commented 3 years ago

@velaar @benbender Is that DSDT patch still needed for v7 or not?

buyddy commented 3 years ago
Screen Shot 2020-11-11 at 3 18 07 PM

Did a nvram rest and cold boot, now it is showing 0:00.

buyddy commented 3 years ago

I think the issue is reading the current Amperage wrong.

benbender commented 3 years ago

Yeah, it can't read stuff if half of your SSDTs are broken. Start fresh from @tylernguyen repo please.

PS: I think I will this issue as it gets way out of track.

If you experience issues rooted in my work, please open a new one specific to that issue so it can be tracked properly and only the people get noticed who are affected or interested.

buyddy commented 3 years ago

@benbender I have went back to v6 and everything is fine now. Nothing else changed. What could possibility be the difference? I think most of the ACPI error is because I disabled TB3 in bios. Not sure if anything related to BATX.

buyddy commented 3 years ago

Do I have to use all of your ssdt for v7 to work? I saw you have updated a lot of ssdt. I was using tylernguyen's SSDT but simply replace the battery module with yours. Other than that, the only thing that I have changed was DYTC, but I don't think it is related.

benbender commented 3 years ago

@buyddy There are many more errors in your logs. Make your SSDT load cleanly before doing anything else. SSDT-BATX runs without any dependencies. So no, you are probably not required to use anything else for it.

Read https://dortania.github.io/Getting-Started-With-ACPI/. Get a clean working setup for your start. Start by changing small things and gain experience. ATM you seem to fly quite blindly ;)

buyddy commented 3 years ago

@benbender I think I will try to use all your dsl and see if I can get a clean load. BTW, is there still a 2W power surge with your new TB ssdt (without Bios-assisted mode)? If I understand it correctly, this power surge is caused by USB3.1?

benbender commented 3 years ago

@buyddy To be honest, I think you should learn the basics first. Go for the dortania tutorials. Build your own set of patches after their tutorials. Read the specs.

My work here is quite unstable and experimental. There are dependencies between those SSDTs. It's not as simple as probing one after the other.

For your other question: I'm having an idle power-draw between 0.7-0.8W with working PM on the TB-controller. The TB-controller is a quite complex piece of hardware with very special handling in OSX which is very different as in Windows. It consist's of 4-5 PCI-subdevices (depending on how you are counting), two firmwares, massive ACPI-patches + a (quite unstable) connection controller. Part of this mess is the USB 3.1 Gen2-controller (which is unuseable atm while having working PM).

Especially PM & sleep/wake are quite delicate as many parts of the HW, FW & OS have to play very well together to make it properly work.

buyddy commented 3 years ago

@benbender I am not trying to be a pro like you, just try to stand on the giant's shoulder and help with testing :) I tried your ACPI files, same thing. V7 for battery is just not working. I start to wonder if we have a different battery (and hence the battery controller itself is slightly different). Also while on your ACPI, my PM is still >2W. Do I need to "force" power in BIOS (this is the setting I am using)? Also I see you have provide information on every PCIE devices, is that necessary to get the PM working?

benbender commented 3 years ago

@benbender I am not trying to be a pro like you, just try to stand on the giant's shoulder and help with testing :)

Thats kind, but I'm far from being a pro. i know that i know nothing ;) I'm only stumbling around on that low-level-stuff, try to create something out of it and learning along the way. But as I said: Start with the basics... Try to built something you understand. That's what I do and did. You'll get better each time.

I tried your ACPI files, same thing. V7 for battery is just not working.

"Not working" is no bug-report. And that claim is also simply not true. It may have edge-cases I'm not aware of yet, but its working - for sure. For me and for others.

I start to wonder if we have a different battery (and hence the battery controller itself is slightly different).

Nope. Absolutely sure. The interface/EC-Layout I'm using is stable since at least x50-series of thinkpads.

Also while on your ACPI, my PM is still >2W.

As I said: "Especially PM & sleep/wake are quite delicate as many parts of the HW, FW & OS have to play very well together to make it properly work."

Do I need to "force" power in BIOS (this is the setting I am using)? Also I see you have provide information on every PCIE devices, is that necessary to get the PM working?

Nope.

Again: My advice is to start a little bit lower. Built something from the ground after a tutorial. Gain some experience. If you want to go along with this route: Learn some basic linux tools to handle the log-files (thats what I do) or learn the log-semantics of OSX (man log). Read your logs and try to fix your ACPI-errors first before anything else. You had plenty above...

buyddy commented 3 years ago

@benbender I have managed to get rid of all the ssdt loading errors. Still two issues remained

  1. SB.PCI0.RP09.UPSB.DSB2 is not found in my DSDT, therefore I cannot load SSDT-XHC2. If I understand this correctly, your ssdt-TB defines it?
  2. If I disable SSDT-XHC2, I have no ssdt loading error. However there is still one error: 2020-11-12 15:39:26.596529-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER, 2020-11-12 15:39:26.596531-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0

Could you provide any guidance on this?

As for the battery, I think it is not related to ssdt errors. Maybe it is the charging limit I set in Windows? Cannot think of anything else.

benbender commented 3 years ago

@benbender I have managed to get rid of all the ssdt loading errors. Still two issues remained

  1. SB.PCI0.RP09.UPSB.DSB2 is not found in my DSDT, therefore I cannot load SSDT-XHC2. If I understand this correctly, your ssdt-TB defines it?

yes, its in TB

  1. If I disable SSDT-XHC2, I have no ssdt loading error. However there is still one error: 2020-11-12 15:39:26.596529-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) ACPI Exception: AE_BAD_PARAMETER, 2020-11-12 15:39:26.596531-0600 0x71 Default 0x0 0 0 kernel: (AppleACPIPlatform) Could not install PciConfig handler for Root Bridge PCI0

Its normal. Even present on linux. No known fix for this. You can ignore this one.

Could you provide any guidance on this?

As for the battery, I think it is not related to ssdt errors. Maybe it is the charging limit I set in Windows? Cannot think of anything else.

Hints to check: SSDT-BATX has a debug-mode. You can view the devices known to OSX via IORegistryExplorer. There needs to be a BATX-device. If that's all correct you also need a working Lilu, VirtualSMC + SMCBatteryManager-setup. Somewhere between these parts is your error. Cant specify where.

buyddy commented 3 years ago

yes, its in TB

Is it because we have different address for SB.PCI0.RP09.UPSB.DSB2 that cause the device look up fail and having "Namespace lookup failure, AE_NOT_FOUND"? My SSDT-TB is loaded successfully.

Hints to check: SSDT-BATX has a debug-mode. You can view the devices known to OSX via IORegistryExplorer. There needs to be a BATX-device. If that's all correct you also need a working Lilu, VirtualSMC + SMCBatteryManager-setup. Somewhere between these parts is your error. Cant specify where.

Screen Shot 2020-11-13 at 1 49 55 PM

I do have the BATX device. I am sure Lilu and other stuff are working, as V6 performs as expected with the same setup. How do I activate the debug-mode for SSDT-BATX? Can you tell me where to look for error information?

benbender commented 3 years ago

@buyddy So SSDT-BATX is not loaded. Again: Its a problem with your config. Fix it.

For the DSB2-issue: I have another report about this and will have a look. I'll lock this conversation now as its not your personal help thread and BATX works fine as far as I know. For specific, reproduceable bugs, please open another issue.