benbhansen-stats / propertee

Prognostic Regression Offsets with Propagation of ERrors, for Treatment Effect Estimation (IES R305D210029).
https://benbhansen-stats.github.io/propertee/
Other
2 stars 0 forks source link

`cov_adj` returns NA if covariance adjustment model is not a full rank fit #105

Closed jwasserman2 closed 1 year ago

jwasserman2 commented 1 year ago

In a similar vein to the note I made on issue #89, cov_adj needs to handle a model whose design matrix and fit are less than full rank. As I did in the other issue, I will adopt the stats package's method of handling it: when making predictions, drop the columns of the design matrix whose corresponding regression coefficients weren't estimated.