search

benbhansen-stats / propertee

Prognostic Regression Offsets with Propagation of ERrors, for Treatment Effect Estimation (IES R305D210029).
https://benbhansen-stats.github.io/propertee/
Other
2 stars 0 forks source link

convert tibbles to data frames? #174

Closed benthestatistician closed 4 months ago

benthestatistician commented 6 months ago

In #173 Adam S addresses some trouble that can be traced to his use of tibbles. The immediate problem's been solved, but let's consider whether we want to check any data frames the user provided us for tibble-ness, and if so strip off the tibble class (so that our code doesn't get confused).

josherrickson commented 6 months ago

I'm on board with this. Any reason not to cast as.data.frame to all input?

benthestatistician commented 6 months ago

I couldn't think of any myself.

benthestatistician commented 5 months ago

The consensus being that this is a good idea, I've removed the discussion label here.