laher
commented
1 year ago Some open points:
-
I don't know what to do with Maps and Sets. Should those also have equivalent HOFs? Or instead should there be a way to easily convert them to lists, and back again? e.g.
func (s Set[T]) AsList() List[T],func (m Map[K,V]).AsEntries() List[Entry[K,V]](I guess this would warrant an an Entry type). I like the conversion to list, because it means less code for each HOF. Also I think it would be beneficial to easily transform between Lists/Sets/Maps. -
You can't introduce a new generic type as part of a method declaration, but you can in a bare function. What do we think about a bare func which converts a list of one type to a list of another type? e.g.
func immutable.MapTo[F any, T any](from immutable.List[F], mapper func (F) T) List[T] { ... }
benbjohnson
Some https://github.com/benbjohnson/immutable/issues/27 for Lists
.Map(), .Filter(), .Each(). Seems enough for many use cases.
Each()provides the means to approximate other HOFs like Reduce - you could use a closure on a target variable.Note that Go generics don't allow you to introduce a new generic type in method definitions (although bare functions are allowed to declare generic types), so we're limited in what we can do in these methods. So it's not straightforward to .Map() to a list of a different type, or to .Reduce() to a different type. It's easiest to just support
Each()and leave it to the caller to use closures.