search

benblazak / ergodox-firmware

firmware for the ergoDOX keyboard
Other
596 stars 294 forks source link

Is 80 key version of ergodox supported in your code ? #76

Closed shtumf closed 8 years ago

shtumf commented 8 years ago

Hi,

I have an 80 key ergodox keyboard, does your code support 4 additional keys ?

shtumf commented 8 years ago

I belive it is k15 k16 k17 k18 are the one I need to work. Hmm. I found it in matrix.h file.

benblazak commented 8 years ago

Good to go then? It's been a while since I wrote it, but it sounds like you're looking in the right place :-)

shtumf commented 8 years ago

I managed to change the layout the way I need it also enabled the 4 additional keys, but now 2 aditional keys are not working as it should. What happens is that when I press the key, the key behaves like it didnt get the command to stop being pressed. For example if I press the letter "R" then this letter keeps repeating it self. Do you maybe know is this a faulty switch or a programming error or wrong debounce time ? What is the recommended debounce time for greetech brown switch ? I tried 1ms and 10 ms and 5 ms, but it doesnt make a difference my key still repeats it self. Because the key repeats other keys cant be pressed. I have to unplug the keyboard and plug it in again then the reast of the keys work, but not the 2 keys.

benblazak commented 8 years ago

Were the keys repeating before you changed the firmware? Also, what branch are you using? It sounds me like you're using "master" and you misplaced something in the layout matrices (which is really easy to do, which is why I changed that in "partial-rewrite").

shtumf commented 8 years ago

The keys were not functional before the firmware change, it had 0 istead of a function. I am using master branch. Should I try to compile with your new code, with your partial-rewrite ?

shtumf commented 8 years ago

OK I tried qwerty--ben layout. the addtional keys have "nop" values. This means no option ? If I change "nop" value to "arrowL" value in qwerty--ben layout this seems it is not enough because nothing happens. What I mean is that the "arrowL" key doesnt work on the new position. In the master brench this was different, I had to change the value for the key on two positions in the layout file. Anyway my question is, is it enough to just change the nop values to some key, or do I need to do changes in some other files too ?

shtumf commented 8 years ago

OK so now if I assign "F" to the key. it works and it doesnt reopeat it self. :) Will try again the arrowD and report what happens.

shtumf commented 8 years ago

Okey it works ! :) partial-rewrite branch is working better for me, I probably made a mistake in master brach layout files, still dont know what went wrong. But whats important all 4 additional keys are working. YES ! :) I am very happy ! Would also like to thank you for writing this code for me and other people. You are really great ! :) Bye !

benblazak commented 8 years ago

Glad you got it working!