search

benblazak / ergodox-firmware

firmware for the ergoDOX keyboard
Other
596 stars 294 forks source link

bug report #79

Closed ags799 closed 8 years ago

ags799 commented 8 years ago

I'm writing a layout for my ErgoDox EZ, purchased a week ago, and functioning as expected.

With this change (I changed one key from 1 to _grave), I encounter a bug with the generated layout. Everything works fine except for the changed key. When I press the changed key, the expected backtick (`) is not produced. There is no character produced at all. And when I press another key, all three of the keyboard's status lights (caps lock, scroll lock, num lock), turn on and stay on. I press more keys and the lights stay on, and no characters are produced.

Any idea what could be going on here? Thanks.

benblazak commented 8 years ago

I just have my phone right now so I can't check easily, but it looks like you might also need to change the corresponding entry in the other two matrices.

ags799 commented 8 years ago

Thanks for looking into this. I have updated the remaining layers so that this key is _grave on layer 0 and 0 on all other layers. The problem remains. I forgot to mention that I have successfully remapped other keys on the keyboard.

benblazak commented 8 years ago

Ahhh. Yes, so you did update the one of the other layers (which actually, you probably shouldn't do). But you need to update the corresponding entries in the other two matrices. This type of problem is one of the reasons I changed they way layouts are done in the partial-rewrite branch.

benblazak commented 8 years ago

(since it won't let me add line comments far enough down)

line 168 : lpush1 should probably be kprrel in the position corresponding to the key you're changing

line 266 : NULL should probably be kprrel in the position corresponding to the key you're changing

The "probably"s in there are because it's been a while, and I haven't tested this :-)

ags799 commented 8 years ago

Yep that did it! Thanks Ben!

benblazak commented 8 years ago

:)