search

benbovy / spherely

Manipulation and analysis of geometric objects on the sphere.
https://spherely.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
119 stars 8 forks source link

Add logo, readme and doc tweaks #13

Closed benbovy closed 1 year ago

benbovy commented 1 year ago

A brand new logo (based on S2 cells) + a few minor changes in Readme and docs (changed the theme to sphinx-book-theme).

jorisvandenbossche commented 1 year ago

Nice ;) I do like the logo, two comments: 1) technical nit, the svg file seems truncated? (the last part of "spherely" is cut off, here on github but also in a local viewer), and 2) the typical feedback will be that it has to many small details when the logo is shown in a smaller format?

benbovy commented 1 year ago

Thanks for the feedback @jorisvandenbossche :)

1) technical nit, the svg file seems truncated? (the last part of "spherely" is cut off, here on github but also in a local viewer)

Hmm that's weird? It looks good in my browser..

Screenshot 2022-12-20 at 10 23 14 Screenshot 2022-12-20 at 10 23 38

the typical feedback will be that it has to many small details when the logo is shown in a smaller format?

Yes I agree there's a lot of details (which also makes the svg file pretty heavy for a logo). Maybe we could remove the S2 cells thin boundaries? I kind of like it, though.

benbovy commented 1 year ago

The preview on MacOS is indeed truncated.

martinfleis commented 1 year ago

We should also have a png versions. Those can also then be used in docs if svg proves tricky.

I think that in this case the level of detail is okay as the logo itself seems to work when tiny as well. You just see the large shapes which is okay to me.

benbovy commented 1 year ago

I've updated multiple versions of the logo (with / without cell border lines) that can be used depending on the size. I also added png exports + a favicon.

spherely_logo_large

spherely_logo_noline_medium

favicon copy

benbovy commented 1 year ago

Ok, thanks! Merging. (it is truncated when seeing the svg file with MacOS's Finder preview -- maybe an issue with svg thumbnails? -- but it looks good in web browser indeed).

jorisvandenbossche commented 1 year ago

I have the same issue with the cut-off image in the README:

image

But so this might be something Firefox specific (or Firefox+linux), since in chrome it looks better. Still, it would be nice to fix this (there are still some people that use Firefox ;))

martinfleis commented 1 year ago

I guess because the text is still as a text and you don't have the font instead of the text being in curves. We should fix that.

benbovy commented 1 year ago

It looks indeed like a font issue, hopefully fixed in f86f6a0. @jorisvandenbossche does it look good now?

Thanks for raising this.

there are still some people that use Firefox ;)

Including me :-)

jorisvandenbossche commented 1 year ago

Indeed, that works fine now! (and also much better looking with a nice font instead of that serif font ;))