search

benbovy / spherely

Manipulation and analysis of geometric objects on the sphere.
https://spherely.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
119 stars 8 forks source link

Add centroid, boundary and convex_hull function (returning new Geography) #20

Closed jorisvandenbossche closed 3 months ago

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 44.73% and project coverage change: -1.46 :warning:

Comparison is base (e874e60) 56.07% compared to head (91ce98f) 54.61%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ========================================== - Coverage 56.07% 54.61% -1.46% ========================================== Files 5 6 +1 Lines 214 249 +35 Branches 95 114 +19 ========================================== + Hits 120 136 +16 Misses 7 7 - Partials 87 106 +19 ``` | [Impacted Files](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy) | Coverage Δ | | |---|---|---| | [src/geography.cpp](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy#diff-c3JjL2dlb2dyYXBoeS5jcHA=) | `41.66% <ø> (-0.27%)` | :arrow_down: | | [src/accessors-geog.cpp](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy#diff-c3JjL2FjY2Vzc29ycy1nZW9nLmNwcA==) | `37.93% <37.93%> (ø)` | | | [src/geography.hpp](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy#diff-c3JjL2dlb2dyYXBoeS5ocHA=) | `83.33% <50.00%> (-4.17%)` | :arrow_down: | | [src/pybind11.hpp](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy#diff-c3JjL3B5YmluZDExLmhwcA==) | `82.14% <75.00%> (-0.47%)` | :arrow_down: | | [src/spherely.cpp](https://codecov.io/gh/benbovy/spherely/pull/20?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy#diff-c3JjL3NwaGVyZWx5LmNwcA==) | `57.14% <100.00%> (+7.14%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Benoit+Bovy)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jorisvandenbossche commented 1 year ago

@benbovy this should be ready I think. There are certainly some things to improve (easier testing, correct return class), but those can be left for follow-ups I think.