search

benbovy / spherely

Manipulation and analysis of geometric objects on the sphere.
https://spherely.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
116 stars 8 forks source link

CI: build sdist and wheels (Linux & MacOS) #35

Closed benbovy closed 2 months ago

jorisvandenbossche commented 2 months ago

BTW, if you update

https://github.com/benbovy/spherely/blob/38d3bf9df81e86140dacb962b573fc95e44f9316/pyproject.toml#L21-L21

to >=3.10 then it should autmatically limit the wheels to those python versions (not that it will the error, but I just noticed it was building and testing a python 3.7 wheel, and we don't really need to provide wheels for that many python versions)

I bumped testing to use Python 3.10+ (https://github.com/benbovy/spherely/pull/36), so matching our requirements to that might be best.

benbovy commented 2 months ago 
libssl.3.dylib has a minimum target of 13.0

Looks like we'll need to build and install openssl manually on macos :-/

jorisvandenbossche commented 2 months ago 
libssl.3.dylib has a minimum target of 13.0

Looks like we'll need to build and install openssl manually on macos :-/

Could also (or at least for now) bump the deployment target (it just means the wheels are only installable on recent macos)

jorisvandenbossche commented 2 months ago

Success! Will have to add an upload step now to further verify that it actually works

benbovy commented 2 months ago

Success!

Yes finally!

We'll need to add windows too (maybe in a follow-up PR).

benbovy commented 2 months ago

We'll also need to include the licenses of the dependencies in the wheels.

benbovy commented 2 months ago

Everything is green! I'm going to merge this PR now and release 0.0.1 so we can test if all the files are correctly uploaded to pypi. I'm also going to submit a PR to conda-forge/staged-recipes.

jorisvandenbossche commented 2 months ago

Great!