benbria / aliasify

Rewrite require calls in browserify modules.
MIT License
204 stars 26 forks source link

Issues when using npm shrinkwrap or npm ls because of node-falafel #15

Closed gionkunz closed 9 years ago

gionkunz commented 9 years ago

Hi there

There is a long running issue with node-falafel that uses esprima as a bundledDependencies https://github.com/substack/node-falafel/blob/master/package.json#L25 and therefore causing "ERR! extraneous: esprima@1.1.0-dev".

There are several issues already open and even pull requests: https://github.com/substack/node-falafel/issues/30 https://github.com/substack/node-falafel/issues/28 https://github.com/substack/node-falafel/pull/29

I don't understand why this doesn't get fixed. I respect substack and understand he has a lot on his plate but this issue is going on for too long and it'd just be a matter of accepting a PR.

As a workaround I could see the following options:

What do you think?

Cheers Gion

gionkunz commented 9 years ago

Sorry this issue should go to browserify-transform-tools

scamden commented 9 years ago

@gionkunz why does this go to browserify-transform-tools? bundling the dep and not declaring it in your package.json is breaking shrinkwrap for anyone that uses falafel

jwalton commented 9 years ago

Sounds like this is fixed in the latest falafel? I've upgraded browserify-transform-tools to use falafel@1.0.1, and updated aliasify to use the latest browserify-transform-tools. Let me know if this is still a problem.

gionkunz commented 9 years ago

Coolio!