benbria / bunyan-debug-stream

A stream for bunyan that writes log entries as human readable output.
MIT License
30 stars 9 forks source link

Make metadata printing optional #9

Closed noomorph closed 5 years ago

noomorph commented 5 years ago

Hi over there! Is the project alive? Ping! Please send pong. :ping_pong:

Motivation

Sometimes metadata objects (that are helpful for analyzing the logs post factum) stand in the way of clarity of console logs printed real-time.

Before pull request: screenshot from 2018-07-16 16-59-47 After pull request: screenshot from 2018-07-16 17-00-11

Code changes

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 60.699% when pulling c9432cce12475f6298536f14c12b42b69d40162e on noomorph:feat/optional-print-metadata into af9136a7b3d75cf550d584b06011339baeef30c1 on benbria:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 60.699% when pulling c9432cce12475f6298536f14c12b42b69d40162e on noomorph:feat/optional-print-metadata into af9136a7b3d75cf550d584b06011339baeef30c1 on benbria:master.

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.3%) to 60.699% when pulling c9432cce12475f6298536f14c12b42b69d40162e on noomorph:feat/optional-print-metadata into af9136a7b3d75cf550d584b06011339baeef30c1 on benbria:master.

noomorph commented 5 years ago

@jwalton, it seems like you moved entirely to winston logging, but anyways your project does not appear to be that bad - at least it satisfies our current stdout logging needs except this missing feature.

Could you look somewhat sooner into the proposed change? The scope is quite minimal, so I think it should not take too much time.

jwalton commented 5 years ago

Hey, sorry - was on vacation all last week. Happy to merge this. :) Can you submit another PR with a description of this option to README.md though, please?

noomorph commented 5 years ago

Sure, thanks much!!

benbriadeploy commented 5 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: