search

benbria / coffee-coverage

Istanbul and JSCoverage-style instrumentation for CoffeeScript files.
MIT License
145 stars 31 forks source link

globs with leading forward slash should match relative to project root #77

Open doublerebel opened 8 years ago

doublerebel commented 8 years ago

It looks like when glob package was swapped out for minimatch, we accidentally lost the ability to match globs with a leading forward slash.

I'm first pushing the failing test to serve as example, then pushing the fix. I can squash these if needed.

Sidenote: my master branch is a working version of coffee-coverage for Iced CoffeeScript. It's almost perfect and backwards compatible, but will require upkeep so I haven't made a PR for it against the main package. This package is really useful, thanks!

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.03%) to 78.372% when pulling 09cd39bd15347d1c3323fe236c4197f331a991a7 on doublerebel:fix/project-root-glob into 6295ef5a253ebf4c0df14e82976e06f5bc908736 on benbria:master.

STRd6 commented 2 years ago

@doublerebel Thanks for the fix, I've merged it into my fork which also includes CoffeeScript 2.6.1 support here: https://github.com/DanielXMoore/CoffeeCoverage