benbria / coffee-coverage

Istanbul and JSCoverage-style instrumentation for CoffeeScript files.
MIT License
145 stars 31 forks source link

Support CoffeeScript v2 #91

Closed etamponi closed 6 years ago

etamponi commented 7 years ago

This PR is an attempt to support CoffeeScript v2.

All tests pass, and I've tested it on one of my services just ported to CoffeeScript v2, and it runs fine.

I must admit the changes will seem... hacky. And they totally are :P but at least it runs, so perhaps people more experienced than me with compilers and ASTs might start from here to make this a real thing.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.2%) to 74.605% when pulling 9f275eeed896ae10773cc35dbc127f5bf1b3ac72 on etamponi:master into 36e891203b1737b95780df62ea16be52d4e544e1 on benbria:master.

jwalton commented 6 years ago

This all looks fine. Do you know why this is failing in travis right now though? https://travis-ci.org/benbria/coffee-coverage/builds/303496827?utm_source=github_status&utm_medium=notification

etamponi commented 6 years ago

It looks like Travis cannot find coffee, it is failing with a ENOENT and a sh: 1: coffee: not found error

etamponi commented 6 years ago

Perhaps I know why, I'll try to push a small change

jwalton commented 6 years ago

Looks like it's the "preinstall" script. If I clone your repo and npm install, same thing happens.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.2%) to 74.605% when pulling 306d5211c7c7e456a27a22b42460009577325cbf on etamponi:master into 36e891203b1737b95780df62ea16be52d4e544e1 on benbria:master.

jwalton commented 6 years ago

Oh yeah, you found it. :)

jwalton commented 6 years ago

Now it's failing on node 4 and node 5, but I think it's coffee-script that's failing. Ok, I'll merge this.

jwalton commented 6 years ago

Published as v3.0.0. Thanks!

GeoffreyBooth commented 6 years ago

Now it’s failing on node 4 and node 5

CoffeeScript 2 is Node 6+.

etamponi commented 6 years ago

I got rid of that dependency in the following commit, anyway it's not used in coffee-coverage 3.0 because it uses another commit

Il 14 dic 2017 00:40, "Geoffrey Booth" notifications@github.com ha scritto:

@GeoffreyBooth commented on this pull request.

In .travis.yml https://github.com/benbria/coffee-coverage/pull/91#discussion_r156818183 :

@@ -7,7 +7,7 @@ node_js:

Install latest npm, because node v0.8 comes with npm v1.2.30, which doesn't like ^s in

package.json.

before_install:

    • "npm install -g npm@'>=1.4.3'"
    • "npm install -g npm@'>=1.4.3' coffee-script"

CoffeeScript on NPM has moved to coffeescript.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benbria/coffee-coverage/pull/91#pullrequestreview-83357828, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjUNI3LjQ20YinQBx8gl8EEfMpLcnEPks5tAGBvgaJpZM4QZwGl .

benbriadeploy commented 5 years ago

:tada: This PR is included in version 2.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: