Closed etamponi closed 6 years ago
This all looks fine. Do you know why this is failing in travis right now though? https://travis-ci.org/benbria/coffee-coverage/builds/303496827?utm_source=github_status&utm_medium=notification
It looks like Travis cannot find coffee
, it is failing with a ENOENT and a sh: 1: coffee: not found
error
Perhaps I know why, I'll try to push a small change
Looks like it's the "preinstall" script. If I clone your repo and npm install
, same thing happens.
Oh yeah, you found it. :)
Now it's failing on node 4 and node 5, but I think it's coffee-script that's failing. Ok, I'll merge this.
Published as v3.0.0. Thanks!
Now it’s failing on node 4 and node 5
CoffeeScript 2 is Node 6+.
I got rid of that dependency in the following commit, anyway it's not used in coffee-coverage 3.0 because it uses another commit
Il 14 dic 2017 00:40, "Geoffrey Booth" notifications@github.com ha scritto:
@GeoffreyBooth commented on this pull request.
In .travis.yml https://github.com/benbria/coffee-coverage/pull/91#discussion_r156818183 :
@@ -7,7 +7,7 @@ node_js:
Install latest npm, because node v0.8 comes with npm v1.2.30, which doesn't like
^
s inpackage.json.
before_install:
- "npm install -g npm@'>=1.4.3'"
- "npm install -g npm@'>=1.4.3' coffee-script"
CoffeeScript on NPM has moved to coffeescript.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/benbria/coffee-coverage/pull/91#pullrequestreview-83357828, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjUNI3LjQ20YinQBx8gl8EEfMpLcnEPks5tAGBvgaJpZM4QZwGl .
:tada: This PR is included in version 2.0.2 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
This PR is an attempt to support CoffeeScript v2.
All tests pass, and I've tested it on one of my services just ported to CoffeeScript v2, and it runs fine.
I must admit the changes will seem... hacky. And they totally are :P but at least it runs, so perhaps people more experienced than me with compilers and ASTs might start from here to make this a real thing.