Minimized Programs have tray icon hidden

benbuck / rbtray

A fork of RBTray from http://sourceforge.net/p/rbtray/code/.

GNU General Public License v2.0

1.08k stars 89 forks source link

Minimized Programs have tray icon hidden #2

Closed coderb closed 7 years ago

coderb commented 7 years ago

I know you're not the author but you seem to have a dev environment setup to build this.

Could you (pretty please :-) )add an error check for Shell_NotifyIcon() failure and not hide the window in this case (eg don't call ShowWindows(SW_HIDE)).

People (including me) are experiencing "lost" windows that get hidden with no tray icon under Windows 10.

see https://sourceforge.net/p/rbtray/bugs/28/

benbuck commented 7 years ago

Do you know of a way to reproduce this? I use RBTray with Win10 daily and haven't seen this.

coderb commented 7 years ago

hi ben- not really. it's pretty inconsistent but i've seen it with lots of tray-minimized windows. but hey, error checking can't hurt, right?

benbuck commented 7 years ago

I'm wondering if you've tried my 64 bit build of RBTray, I'm hopeful that might work for you (and would explain why I don't see this problem). https://github.com/benbuck/rbtray/tree/master/x64

benbuck commented 7 years ago

I went ahead and added some error checking, but I have no way to test whether it works or not. Please try it out and let me know.

coderb commented 7 years ago

looks fantastic. will give it a shot! thank you!!!

coderb commented 7 years ago

seems to be working with no issues. the shift-caption trick is also a nice touch!

coderb commented 7 years ago

hey ben- i found a minor problem that doesn't seem to exist in the original version.

maximize 2 console windows
mintotray 1 of them (keep the other in the foreground)
restorefromtray and it is behind (zorder) the other window

i went back and tested with 4.3 and this doesn't seem to happen.

just a guess, but perhaps the fix is to change get rid of the return statement if ShowWindow(hwnd, SW_SHOW) returns false and always call the foreground/tray remove functions.

benbuck commented 7 years ago

Strange, I can't reproduce this either, but I suspect you're right. I updated the build again, please let me know if it works

coderb commented 7 years ago

yes indeed, that is quite nice- everying is perfect! must be something weird about my environment. let's see: i have dual montiors, intel graphics, taskbar moved to the left of the screen (as opposed to the bottom).

anyway- wow, it's nice to have rbtray working again!

benbuck commented 7 years ago

Closing this since it seems to be resolved. Please let me know if you find any more issues.