bencagri / mokka

Free and extendable trading bot application for crypto currencies.
MIT License
22 stars 15 forks source link

LOT_SIZE error #6

Open FreshLondon opened 6 years ago

FreshLondon commented 6 years ago

Hey @bencagri,

I'm testing your project (before we start, thanks in advance).

Installed, ran, seemed to go ok for a few seconds then I quit to adjust parameters. I changed the default % and see a LOT_SIZE error.

screen shot 2018-05-21 at 03 43 02

I'm assuming this is looking for 2 decimal places, I edited to two and it now works. I'm only reporting this as others may come across the issue, save time!

FreshLondon commented 6 years ago

screen shot 2018-05-21 at 03 48 19

weird.. ill experiment for now

bencagri commented 6 years ago

Hi @CreativeBacon

First thanks for your contribution. The status of the repo is still in progress.

And the LOT_SIZE is a problem that binance gives us. Seems that a lot of user getting this error. https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md#lot_size

This repo uses, larislackers/php-binance and I think I can change it. I need to investigate the exact problem.

If you can do that, I appreciate.

FreshLondon commented 6 years ago

aha, understood. Yes, i saw several similar issues on the web when searching earlier (before my first post).

Have you looked at https://github.com/TinyUlt/node_binance_friedcoin ?

Seems interesting, almost inspiring.. :)

FreshLondon commented 6 years ago

ahhhh, i get what you mean - there is no filter currently in place for LOT_SIZE in the Mokka project?

FreshLondon commented 6 years ago

see here example of a filter in place for each currency pair: https://github.com/askmike/gekko/blob/develop/exchanges/binance-markets.json

Annoying part is that every currency would require a different lot size, maybe extract ones already created from this LONG list? 👍