search

bencbartlett / Overmind

AI for Screeps, a multiplayer programming strategy game
MIT License
545 stars 155 forks source link

Update npcDefense.ts #168

Closed OverlordQ closed 4 years ago

OverlordQ commented 4 years ago

Guard Directive automatically gets placed when the invader core appears, but is a structure so isn't picked up by this.room.invaders so the number of requested guards will always be zero, and so the Invader Cores won't get attacked.

Pull request summary

Description:

Makes sure to actually assign a guard for invader cores

Added:

Changed:

Removed:

Fixed:

Testing checklist:

MatthewARoy commented 4 years ago

This looks good to me. @bencbartlett

ahmedcharles commented 4 years ago

This doesn't seem to pass npm run lint, though I'm not sure why CI doesn't catch that.

OverlordQ commented 4 years ago

The only lint errors I see are in code that isn't touched by this PR.

ahmedcharles commented 4 years ago

Oh, right, sorry. I made the association because it was the same file but I forgot to check whether it was there before.