Switch room status checks to RoomIntel

bencbartlett / Overmind

AI for Screeps, a multiplayer programming strategy game

MIT License

545 stars 155 forks source link

Switch room status checks to RoomIntel #210

Closed tiennou closed 7 months ago

tiennou commented 7 months ago

Pull request summary

Description:

This changes all of the deprecated uses of Game.map.isRoomAvailable to go through RoomIntel.getRoomStatus, which handles caching already, which could have a performance effect since it's costly to check.

Testing checklist:

[x] Changes are backward-compatible
[x] Codebase compiles with current tsconfig configuration
[x] Tested changes on private server

bencbartlett commented 7 months ago

Oh sorry I actually just made an equivalent set of changes here a couple of minutes ago: https://github.com/bencbartlett/Overmind/commit/0e23a85f12d79d9f20b01727db987210cef93924

tiennou commented 7 months ago

Fair. #191 can be closed as well