This cleans up the wrong interface definition we have over Store, which breaks TS since it's a type declaration upstream and not an interface. Also provides specific typings for arrays of store contents, updates most of the definitions that have an object-like store-thing ([resourceType: string]: number;) to an explicit type, and switches all of the deprecated before-Store properties to use the new style as well as using thing.store[RESOURCE_THING] instead of the named property.
Testing checklist:
[x] Changes are backward-compatible
[x] Codebase compiles with current tsconfig configuration
Pull request summary
Description:
This cleans up the wrong interface definition we have over
Store, which breaks TS since it's a type declaration upstream and not an interface. Also provides specific typings for arrays of store contents, updates most of the definitions that have an object-like store-thing ([resourceType: string]: number;) to an explicit type, and switches all of the deprecated before-Store properties to use the new style as well as usingthing.store[RESOURCE_THING]instead of the named property.Testing checklist:
tsconfigconfiguration