search

benceruleanlu / Team-Website

Absolute Robotics' Team Website rewrite project in Next.js
http://team4308.ca/
GNU General Public License v3.0
1 stars 1 forks source link

using sheet for navigation #15

Closed AyaanZaveri closed 3 months ago

AyaanZaveri commented 3 months ago

Replacing the previous hamburgerMenu code with a sheet from shadcn/ui with the same menu items

https://github.com/user-attachments/assets/be820dfa-8e82-4fbd-bf45-9cdfc1e281e9

benceruleanlu commented 3 months ago

sorry, i added the navbar to desktop before i saw this pr.

i don't know if this is really needed since the current hamburger menu and navbar works well.

but the shadcn repo is pretty interesting, i'll take a look to see if anything can be refactored to their style.

if you still want to, feel free to resolve the merge conflicts and lmk so I'll merge it into main.

AyaanZaveri commented 3 months ago

that's all good, I'll see if I can replace anything with the shadcn components