benceszasz / xDripCareLinkFollower

Experimental Medtronic CareLink Follower data source for xDrip+
GNU General Public License v3.0
86 stars 64 forks source link

AAPS data always exposed to local web server #13

Open Trenar opened 2 years ago

Trenar commented 2 years ago

Subject of the issue

This version of xDrip+ always emits an "aaps" string in e.g. http://127.0.0.1:17580/sgv.json?count=24, like

"aaps":"🔺1.658U ⏱1092h2m 📅5d11h","aaps-ts":1644483391375

This is unexpected, since no AAPS connection is made (on my device). Furthermore, I suspect that the special characters / emojis are compatible with AAPS, but this is just a wild guess.

Your environment

xDripCareLinkFollower / master branch / beta 0.1.2

Expected behavior

If no AAPS connection is there, these strings shouldn't be exposed It's related to the file dexdrip/webservices/WebServiceSgv.java, lines 148-153:

// emit the external status line once if present
  if (external_status_line.length() > 0) {
  item.put("aaps", external_status_line);
  item.put("aaps-ts", getLastStatusLineTime());
  external_status_line = "";
} 

Steps to reproduce the behavior:

Set up xDripCareLinkFollower with your minimed connect follower account, and on your phone type http://127.0.0.1:17580/sgv.json?count=24. You'll see the lines quoted above.

Best, Trenar

benceszasz commented 1 year ago

Most of the CareLink Follower functions were merged into the offical xdrip on 02.11.2022. Since extra status line and external status functions of CareLink Follower were not merged, you can use the official xdrip without this issue.

Trenar commented 1 year ago

Hi, thx for the reply. Meanwhile, I moved towards using Nightscout with the mmed plugin, which also serves my purposes. Anyway, thanks for your hard work on this :-)