search

bencevans / node-sonos

🔈 Sonos Media Player Interface/Client
https://www.npmjs.com/package/sonos
MIT License
700 stars 146 forks source link

Two tests failing #460

Closed svrooij closed 3 years ago

svrooij commented 4 years ago

Two tests are failing:

  1) Sonos - Device
       should getMusicLibrary("sonos_playlists"):
     AssertionError [ERR_ASSERTION]: should have items
      at /Users/stephan/Projects/node-sonos/test/sonos.test.js:563:7
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

  2) Sonos - Device
       should getPlaylist():
     AssertionError [ERR_ASSERTION]: should have items
      at /Users/stephan/Projects/node-sonos/test/sonos.test.js:575:7
      at processTicksAndRejections (internal/process/task_queues.js:94:5)

Not sure if it matters, can someone check it out if they can still use the sonos.getMusicLibrary('sonos_playlists') and sonos.getPlaylist('1') functions

Possible Solution

Fix or remove the tests

Sample code or executed example

  1. SONOS_HOST=192.168.x.x npm run test

Versions (and Environment)

Node version: 12.15.0 node-sonos version: latest master OS: Mac

OrionTheGiant commented 3 years ago

I'm trying to use this library for the first time and trying to get the playlists returned from the getMusicLibrary() function with no luck. Other functions like DeviceDiscovery and currentTrack work so I know the connection is being made to the speaker but no matter what I try I only receive {"returned":"0","total":"0","updateID":"0"} from getMusicLibrary(). Seems like it could be related to this issue.

svrooij commented 3 years ago

@hunter-hunter I closed the issue because two of the previous used tests stopped working. If you are having issues with the library, it’s best to create a new issue.

We have a template configured to specify all the details about your environment.

OrionTheGiant commented 3 years ago

Thank you. I created a new issue #487