Closed pascalopitz closed 4 years ago
SetBass and SetTreble values should be in range -10 to 10, integer.
Yes, quite sure. Also spotted another copy paste mistake I made while trying to confirm to the coding style. I normally don't use comments unless it's an absolute gotcha, so am quite snow blind when it comes to docblocks. Apologies in both instances.
I think this PR is getting pretty big, for us to be able to check it easily I would rather see in broken down in smaller pieces.
Because the first part doesn't need a lot of testing, but the second one would require a lot of manual testing (since we don't test every custom method defined there).
An other solution would be for us to release an alpha version to npm and let it be tested by various libraries using node-sonos and have it tested by use.
What do you guys think @bencevans @hklages
Ok, I have broken this up into: