bencevans / node-sonos

🔈 Sonos Media Player Interface/Client
https://www.npmjs.com/package/sonos
MIT License
700 stars 146 forks source link

Fixing Bass and Treble setters in RenderingControl #473

Closed pascalopitz closed 4 years ago

pascalopitz commented 4 years ago
svrooij commented 4 years ago

I manually pulled these changes to https://github.com/bencevans/node-sonos/tree/alpha (as a first change to auto-release from the alpha branch).

Could you use the commit message style needed for semantic release next time? That will make sure that when we pull your code it will automatically get released.

So, start with:

pascalopitz commented 4 years ago

Yes, totally ... do you want me to force push commit message updates?

svrooij commented 4 years ago

@pascalopitz the automated releases are all setup. The changes in this pr are already in the alpha branch (but not released because it didn’t pick up commit messages that should trigger a release. I’ll close this one (I merged it to alpha already as a test). Could you force push the others?

pascalopitz commented 4 years ago

Done.

pascalopitz commented 4 years ago

Confirmed it works on my latest release, which is using the alpha package