search

bencevans / node-sonos

🔈 Sonos Media Player Interface/Client
https://www.npmjs.com/package/sonos
MIT License
703 stars 147 forks source link

Sonos now ES6 Class, additional getZPInfo method, additional services… #477

Closed pascalopitz closed 4 years ago

pascalopitz commented 4 years ago

… shorthands

svrooij commented 4 years ago

How do we progress with this PR?

Is everything in de alpha branch still working and tested by anyone?

After the alpha version is checked. We will release a new latest version, and then merge this as the new alpha. This PR has so manu changes that I think it's better to split the releases this way. Everybody agrees?

svrooij commented 4 years ago

Tested:

So I think we can assume everything still works. I'm OK in approving this pr.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.14.0-alpha.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pascalopitz commented 4 years ago

Since we released 1.14.0, should this not be 1.14.1-alpha.1 ?

svrooij commented 4 years ago

Yes it should..... But I didn't push the new master te Alpha before I merged your PR.

So my mistake...

Can we automate that? Push to master = rebase alpha (or similar)

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.15.0-alpha.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

svrooij commented 4 years ago

@pascalopitz or 1.15.0-alpha.1 because you made it a feature 😄

This should be automated asap. After push to master also update alpha, anybody knows which git command we need for that? Then I'll automate it with actions.