bencevans / node-sonos

🔈 Sonos Media Player Interface/Client
https://www.npmjs.com/package/sonos
MIT License
700 stars 146 forks source link

Enhance metadata from original sources if possible #500

Open stufisher opened 3 years ago

stufisher commented 3 years ago

I've tried to isolate the interaction with other services. Enhanced metadata can be enabled by setting ENHANCE_METADATA=true in your env. Works for currently playing and things in the queue.

Some feedback on this would be useful, there are likely things i dont understand about how album art urls are generated, maybe there is a way to dynamically retrieve the radio art url?

svrooij commented 3 years ago

I like the idea to do this, why isn't sonos doing this by itself?

Apart from that, this seems like something that is perfectly testable. Can you create a test for loading the info for some random soundcloud track?

And I see that it’s no longer possible to create a client Id for SoundCloud, but do you really need a separate library just to scrape the client id? A regular expression would be sufficient I guess?

how does this relate to accessing the external music service data directly, like described here