search

bencheeorg / benchee

Easy and extensible benchmarking in Elixir providing you with lots of statistics!
MIT License
1.41k stars 66 forks source link

Add space before ellipsis #334

Closed eksperimental closed 2 years ago

eksperimental commented 3 years ago

It confuses me because it looks like map_100 is trimmed.

Benchmarking first: Map.get with input map_100...

Now it looks:

Benchmarking first: Map.get with input map_100 ...

PragTob commented 2 years ago

Sorry as in all the other MRs for the long wait. Been out with arm/hand problems (which persist but are better).

I like the old version better, but if it confuses you it's worth changing :)

I almost just merged it, but it might break some tests (as some integration tests assert what's logged). Could you rebase with main please? Tests should run again. If not, I can also do it one of these days!

WhatsApp Image 2021-09-19 at 11 39 531

eksperimental commented 2 years ago

Sorry to hear about your arm. I hope you can recover soon. I'm a terrible thing to hurt even worse being a programmer. I will rebase it later today. take care,

PS; that's a cute bunny

PragTob commented 2 years ago

Looks like I did well writing the tests so they don't fail for an added space. Hooray!

Also, thanks :)