bencheeorg / benchee

Easy and extensible benchmarking in Elixir providing you with lots of statistics!
MIT License
1.42k stars 66 forks source link

Migrate GitHub Action to erlef/setup-beam #356

Closed kianmeng closed 2 years ago

PragTob commented 2 years ago

:wave:

Thank you!

I have no idea why, but it seems to be failing now that I hit rerun on them all... do you happen to have an idea why? :thinking:

WhatsApp Image 2021-02-20 at 10 23 00

kianmeng commented 2 years ago

I've tried to duplicate the error found in https://github.com/bencheeorg/benchee/runs/6522818866?check_suite_focus=true

But works for me locally instead:

$ asdf current
elixir          1.12.3          /tmp/benchee/.tool-versions
erlang          22.3            /tmp/benchee/.tool-versions

$ mix dialyzer --halt-exit-status
...
Adding 77 modules to benchee.plt                                                                                     
done in 2m2.77s                                                                                                      
No :ignore_warnings opt specified in mix.exs and default does not exist.                                             

halt_exit_status is no longer a valid CLI argument.                                                                  
Starting Dialyzer                                                                                                    
[                                                                                                                    
  check_plt: false,                                                                                                  
  init_plt: '/tmp/benchee/tools/plts/benchee.plt',                                                                   
  files: ['/tmp/benchee/_build/dev/lib/benchee/ebin/Elixir.Benchee.Conversion.DeviationPercent.beam',                
   '/tmp/benchee/_build/dev/lib/benchee/ebin/Elixir.Benchee.Scenario.beam',                                          
   '/tmp/benchee/_build/dev/lib/benchee/ebin/Elixir.Benchee.Benchmark.Collect.Profile.beam',                         
   '/tmp/benchee/_build/dev/lib/benchee/ebin/Elixir.Benchee.Configuration.beam',                                     
   '/tmp/benchee/_build/dev/lib/benchee/ebin/Elixir.Benchee.Conversion.Count.beam',                                  
   ...],                                                                                                             
  warnings: [:unmatched_returns, :error_handling, :race_conditions, :underspecs,                                     
   ...]                                                                                                              
]                                                                                                                    
Total errors: 0, Skipped: 0, Unnecessary Skips: 0                                                                    
done in 0m1.05s                                                                                                      
done (passed successfully) 

Note that halt_exit_status is no longer a valid CLI argument.

PragTob commented 2 years ago

Yeah no doubt it works locally - the MR just changes CI setup so if something is broken, it's on the CI :) I guess, maybe the caches are somehow incompatible? I'm not sure.

Is there any benefit to switching, toher that well we're then using something by the erlang foundation? :D

kianmeng commented 2 years ago

Is there any benefit to switching, toher that well we're then using something by the erlang foundation? :D

https://github.com/erlef/setup-elixir redirected to https://github.com/erlef/setup-beam, which I assumed erlef/setup-elixir is not maintained any more?

PragTob commented 2 years ago

I see! Thanks, sorry most of the GH actions setup was done by other folks :sweat_smile:

Let me see if removing cash or something fixes this.

PragTob commented 2 years ago

Adapted and merged in #364 - thank you!

kianmeng commented 2 years ago

FYI, related to https://github.com/erlef/setup-beam/issues/20.