search

bencheeorg / benchee

Easy and extensible benchmarking in Elixir providing you with lots of statistics!
MIT License
1.41k stars 66 forks source link

Fix deprecation warning #424

Closed mhanberg closed 6 months ago

PragTob commented 6 months ago

The what now? It's running 26.2 why doesn't it have the JIT enabled? MacOS ._.

  1) test .jit_enabled? should say true for versions > 24.0.0 (Benchee.SystemTest)
     test/benchee/system_test.exs:146
     Expected truthy, got false
     code: assert jit_enabled?
     stacktrace:
       test/benchee/system_test.exs:152: (test)
PragTob commented 6 months ago

@mhanberg thanks a lot for the MR, when/how do you trigger the deprecation warning?

I don't see it on tests or a simple example:

Erlang/OTP 26 [erts-14.2.1] [source] [64-bit] [smp:16:16] [ds:16:16:10] [async-threads:1] [jit:ns]

Elixir 1.16.1 (compiled with Erlang/OTP 26)
mhanberg commented 6 months ago

Oh, sorry. It must be a deprecation on 1.17.

I've had to run Elixir main branch on a couple projects and that's where I saw it.

Feel free to close if you'd like to wait for 1.17 to release.

PragTob commented 6 months ago

@mhanberg nah I love it, thank you very much! :green_heart:

Normally the CI pipeline etc. should just catch it though. Might be a nice sign that I should include some level of testing against elixir master and not fail the build but notify me on failures or something.

I'll check it out, on the train right now though :grin:

PragTob commented 6 months ago

Confirmed getting the error on main :sunglasses:

Thanks!

PragTob commented 6 months ago

Merging although a test is failing, but that's confirmed nothing to do with the PR but the elixir/erlang from brew on mac I wager... ._.