tprof :)

[ruslandoga]

👋

Thoughts on adding tprof profiler? It can also potentially allow for more accurate memory measurements (just from reading the docs, I haven't actually used it yet).

Right now using profile_after: :tprof fails with

** (Benchee.Profile.Benchee.UnknownProfilerError) Got an unknown ':tprof' built-in profiler.
    (benchee 1.3.1) lib/benchee/profile.ex:124: Benchee.Profile.profiler_to_module/1
    (benchee 1.3.1) lib/benchee/profile.ex:91: Benchee.Profile.do_profile/4
    (benchee 1.3.1) lib/benchee/profile.ex:85: Benchee.Profile.profile/2
    bench/logger_json_overhead.exs:83: (file)

I'd be happy to contribute! (But again, I haven't used it yet so I am not sure how hard it would be to support)

[PragTob]

:wave: Thanks for coming here! I was gonna say it may be hard, but it may actually be trivial. The reason being, profilers are built on the back of the accompanying mix tasks. But such a mix tasks exists for tprof: https://hexdocs.pm/mix/Mix.Tasks.Profile.Tprof.html

So this might be so trivial, I might just try it straight up :)

That said, I've also been thinking about more general profiler support i.e. eflambe as I saw someone use it in a talk recently :)

Right let me make an issue about that!

[ruslandoga]

Re eflambe / FlameOn / etc., I actually think they might benefit from the new tracer too:

• https://github.com/DockYard/flame_on/issues/48
• https://github.com/Stratus3D/eflambe/issues/50

Right now they use a slightly hack-y approach of mocking the profiled functions which I think can and should be avoided.

So if my suggestions there are accepted, it would be equivalent to using tprof but with some extra wrappers on top. Also neither the currently supported Benchee profilers (fprof is kind of there, but it's too verbose) nor eflambe propagate trace context to the gen:called processes, which results in confusing reports. Like, when setting profile_after: true in Benchee, and profiling a function that calls a GenServer, we wouldn't see what was happening in the GenServer process.

[PragTob]

@ruslandoga sorry eflambe/more generic plugin support for tracers was just a side idea/you reminded me I wanted to open up #440 :)

Thanks for your input/thoughts about them - I'm not very familiar with them!

[PragTob]

@ruslandoga yeah was easy, it's over at #441 I'll need to add some docs and maybe a fail-safe or 2. Are you fine running off that branch or later main or would you need a release? I'd normally wait with a release :)

[ruslandoga]

I'm totally fine running off of that branch. Thank you!