search

bencheeorg / benchee_html

Draw pretty micro benchmarking charts in HTML and allow to export them as png for benchee
MIT License
58 stars 9 forks source link

Open Browser after HTML is generated #23

Closed nscyclone closed 7 years ago

nscyclone commented 7 years ago

Closes #1. I am not sure what exactly was implied in the original issue, but I think that this could be considered a good start. It would also be great to make this PR a part of the Hacktoberfest challenge.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 601765e2b8165461ffd183cc686f7bc1812dc467 on nscyclone:feature/1 into bcca23ecdce337147205a2ae019642c432e9b948 on PragTob:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 601765e2b8165461ffd183cc686f7bc1812dc467 on nscyclone:feature/1 into bcca23ecdce337147205a2ae019642c432e9b948 on PragTob:master.

devonestes commented 7 years ago

Thanks for the contribution! I think it will be part of Hacktoberfest as long as you've signed up. They track all the PRs you open for the month (or at least they did last year). The tags on issues and such are just helpers for folks to find stuff to do.

So this seems like a good way to go for me, but I'd love to see some sort of test for this new behavior. Think you could find a way to add something to test this? It'll be a little tricky because it's dependent on the OS on which the test is run, but with a little creativity I'm sure you can find a design that allows you to test this stuff.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 25b226c59a062d0af9d057bfca2bca6311eaccd0 on nscyclone:feature/1 into bcca23ecdce337147205a2ae019642c432e9b948 on PragTob:master.

nscyclone commented 7 years ago

Thanks for detailed response, @devonestes! I've just reworked open_report/1 to make it accept suite instead of url and updated the test for output/1 with a very simple check.

PragTob commented 7 years ago

:wave:

Yup, some user facing configuration would be nice. If it breaks, as it'll be super hard to make it work on every OS and I don't just wanna error out in all those cases. So a user option might be nice. Not sure what it should default to, I guess if it works on all our machines we could make it the default and wait for the bug reports to pile in :)