bencheeorg / benchee_html

Draw pretty micro benchmarking charts in HTML and allow to export them as png for benchee
MIT License
58 stars 9 forks source link

#6 Add benchee and benchee_html version to version_note #24

Closed azranel closed 6 years ago

azranel commented 6 years ago

This solves #6 . I thought that we can place it together with Elixir and Erlang version. Let me know if you would like to make it a little tidier (wasn't sure if I should merge with system map in formatter).

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 52382f28a32ce74003659b54ab39eb6425dbb3d8 on azranel:add_versions_to_benchee_html into edec00052db84e5761a95ae74f93ece6c1dc29c9 on PragTob:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 52382f28a32ce74003659b54ab39eb6425dbb3d8 on azranel:add_versions_to_benchee_html into edec00052db84e5761a95ae74f93ece6c1dc29c9 on PragTob:master.

PragTob commented 6 years ago

Hi there,

first thanks for the contribution! :tada:

Sorry for the longer delay, I'm not quite sure if I want them there or somewhere else :D

For anyone wondering how it looks like, here is a screenshot:

selection_091

So reason I'm thinking about it is sure it's all versions, but while Elixir/Erlang are "important" versions that might affect the results of the benchmark, the benchee/benchee_html versions are more informative and ideally shouldn't change the result of the benchmark. Therefore, putting them together doesn't feel quite right. On the other hand, putting them there is easiest/most straight forward atm. On the other other hand, we might want to incorporate the whole system information one of these days and then Elixir and Erlang version would likely move somewhere else anyhow :)


Besides that I'd probably want benchee/benchee_html be links to the repos but that's a minor detail.


I sort of still lean towards footer but am not quite sure. @devonestes any opinion/idea/input? :D

devonestes commented 6 years ago

Hmmmm. Well, I agree that incorporating the whole system information is probably the best course of action eventually. For now, though, without all that system information, I think it's best to split up the two. It feels odd to me, too, since which version of benchee you're running won't affect the results of your benchmarks. Maybe we can add a footer with this sort of info (including links to the repos/documentation)?

PragTob commented 6 years ago

Yeah footer with links is also what I envisioned originally in #6 ! Thanks for the input @devonestes :)

@azranel do you want to take stab at moving this into the footer? :)

azranel commented 6 years ago

@PragTob Sure. will move both of those values into footer :)

azranel commented 6 years ago

@PragTob sorry for so long time, had a lot of stuff to do for last couple of days. Anyway, it's here. Let me know if there is any issues or guidelines about the code 😄

PragTob commented 6 years ago

@azranel no worries, life is more important than OSS :)

azranel commented 6 years ago

@PragTob done :)

PragTob commented 6 years ago

Thanks a bunch :tada: