Closed azranel closed 6 years ago
Hi there,
first thanks for the contribution! :tada:
Sorry for the longer delay, I'm not quite sure if I want them there or somewhere else :D
For anyone wondering how it looks like, here is a screenshot:
So reason I'm thinking about it is sure it's all versions, but while Elixir/Erlang are "important" versions that might affect the results of the benchmark, the benchee/benchee_html versions are more informative and ideally shouldn't change the result of the benchmark. Therefore, putting them together doesn't feel quite right. On the other hand, putting them there is easiest/most straight forward atm. On the other other hand, we might want to incorporate the whole system
information one of these days and then Elixir and Erlang version would likely move somewhere else anyhow :)
Besides that I'd probably want benchee/benchee_html be links to the repos but that's a minor detail.
I sort of still lean towards footer but am not quite sure. @devonestes any opinion/idea/input? :D
Hmmmm. Well, I agree that incorporating the whole system
information is probably the best course of action eventually. For now, though, without all that system
information, I think it's best to split up the two. It feels odd to me, too, since which version of benchee you're running won't affect the results of your benchmarks. Maybe we can add a footer with this sort of info (including links to the repos/documentation)?
Yeah footer with links is also what I envisioned originally in #6 ! Thanks for the input @devonestes :)
@azranel do you want to take stab at moving this into the footer? :)
@PragTob Sure. will move both of those values into footer :)
@PragTob sorry for so long time, had a lot of stuff to do for last couple of days. Anyway, it's here. Let me know if there is any issues or guidelines about the code 😄
@azranel no worries, life is more important than OSS :)
@PragTob done :)
Thanks a bunch :tada:
This solves #6 . I thought that we can place it together with Elixir and Erlang version. Let me know if you would like to make it a little tidier (wasn't sure if I should merge with
system
map in formatter).