search

bencheeorg / benchee_html

Draw pretty micro benchmarking charts in HTML and allow to export them as png for benchee
MIT License
58 stars 9 forks source link

Unit Scaling #26

Closed PragTob closed 6 years ago

PragTob commented 6 years ago

Superseds #17

Used the more general unit_scaling configuration option and put in a bunch of cleanup work leftover from the scenarios work. Made units a separate argument as well as units are the same for all scenarios of a group being displayed.

Thanks to original author @elpikel

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1ae79d532526b77b1626c969d509fa83b392219a on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

PragTob commented 6 years ago

Annoyingly dialyzer fails on travis but passes with my local versions on travis --> upgrade versions to see if it's better (maybe all of elixir 1.4 creates weird errors?)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ef3b9027ce6ab2551eecb84bd25a1a60eccdab19 on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 00406685ace821409697f48deca7f346e1da851b on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

PragTob commented 6 years ago

still 3 builds failing. Only one build passing that is not 1.5.2 and runs dialyzer... Theory: PLT doesn't get updated because the benchee version is the same but the struct has changed and dialyzer doesn't care about git hashes. Now to find a way to force upgrade :)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 209550a2d9764104b44776afe73e2133cdf285a0 on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

PragTob commented 6 years ago

ok dialyxir is a good citizen and reads the whole deps.lock and hashes it... unless ther's something I'm missing this isn't the reason :|

PragTob commented 6 years ago

for better or worse, this seems to have worked but the damn excoveralls upload failed again... grrrmlll

PragTob commented 6 years ago

rebased/squashed to get rid off those commits where I tried out CI stuff

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f98b61cfea6f2d0577f8d2d136aaadfc477ba05f on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f98b61cfea6f2d0577f8d2d136aaadfc477ba05f on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f98b61cfea6f2d0577f8d2d136aaadfc477ba05f on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 077dd7c15424dc5745463f75eecc826aed9f43ea on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

PragTob commented 6 years ago

OMG IT PASSES :tada:

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling db03e61c0b64bac2f4d7a23432987d7125ff2222 on elpikel-unit_scaling into edec00052db84e5761a95ae74f93ece6c1dc29c9 on master.

PragTob commented 6 years ago

Hm good questions, standard units code resides in benchee now, I might add some though. Thanks for the ping about that! :)

PragTob commented 6 years ago

and here are the test :grin: