search

bencheeorg / benchee_html

Draw pretty micro benchmarking charts in HTML and allow to export them as png for benchee
MIT License
58 stars 9 forks source link

Option to inline all assets #35

Closed elpikel closed 6 years ago

elpikel commented 6 years ago

I added css and js inlining. I didn't add font inlining - don't know if it is possible to do such thing. I had to push inline_assets all the way down which introduced additional parameter in few function which is probably not the best way to do that.

elpikel commented 6 years ago

https://github.com/PragTob/benchee_html/issues/11

elpikel commented 6 years ago

check this out :)

elpikel commented 6 years ago

@devonestes i changed tests to use implicit after construct.

elpikel commented 6 years ago

@PragTob sorry for the delay i was busy with spawn_fest. I generated base64 font from fontello and inlined it into css which is now inlined html :)

elpikel commented 6 years ago

@PragTob could check out my last commit?

PragTob commented 6 years ago

Hi there, sorry for the delay I was busy with life and stuff - I already saw it and was quite astonished that you managed to do it and was just waiting for a chance to try it out. Will do it now, sorry for the long turnaround.

Happy holidays and thank you! :)

PragTob commented 6 years ago

Looks and works great :tada:

whatsapp image 2017-12-26 at 11 40 30