bencheeorg / benchee_html

Draw pretty micro benchmarking charts in HTML and allow to export them as png for benchee
MIT License
58 stars 9 forks source link

Customize the HTML template #40

Closed tmbb closed 6 years ago

tmbb commented 6 years ago

I'm thinking of including some benchmarks as part of the docs as a way of justifying some implementation choices and a s a teaching tool on how to extend my library.

You can access Benchee's HTML pages form the README (here). I'd like to change the template so that I could add other information, such as a title for the benchmark.

PragTob commented 6 years ago

Hi there,

adding the title as you said in PragTob/benchee#208 seems a good idea. Other information, I'm not sure about. What kind of information would that be?

If it's useful for everyone, let's add it for everyone. Adding custom pieces of HTML seems hard(er) as you also need to specify where it's rendered and when it's rendered and that seems like a lot of overhead. If you have really custom requirements, implementing your own benchee formatter might probably be the better option.

tmbb commented 6 years ago

I agree. I don't need to add the extra link I was thinking about. I just need to use the browser back button.

On Mon, Apr 9, 2018 at 8:34 AM, Tobias Pfeiffer notifications@github.com wrote:

Hi there,

adding the title as you said in PragTob/benchee#208 https://github.com/PragTob/benchee/issues/208 seems a good idea. Other information, I'm not sure about. What kind of information would that be?

If it's useful for everyone, let's add it for everyone. Adding custom pieces of HTML seems hard(er) as you also need to specify where it's rendered and when it's rendered and that seems like a lot of overhead. If you have really custom requirements, implementing your own benchee formatter might probably be the better option.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/PragTob/benchee_html/issues/40#issuecomment-379661563, or mute the thread https://github.com/notifications/unsubscribe-auth/ACi5Son6_IlXYx-swqSFjTqHQmmCfF8cks5tmw8JgaJpZM4TLz6Y .