search

benchen71 / epub-metadata-editor

Edit the metadata of EPUB files
194 stars 11 forks source link

Bug(?) empty subject meta data #75

Closed docjc closed 1 year ago

docjc commented 2 years ago

after using epub-metadata-editor and changing some words eg in title the program is creating an empty subject field at the end of the metadata without haveing edited anything in this field. Is it possible to change this behaviour? It would be better not to create an empty subject (This causes my softwre to get problems ;))

benchen71 commented 2 years ago

I guess it should be possible. But there are a few different scenarios to consider (for example, that there has been a subject but the user has cleared that box). And I don't have as much programming time as I used to!

docjc commented 2 years ago

Hi, its a pity that you have not the time to “repair” the code 😉 cause I like this program, it is just what I’m looking for

attached you’ll find 2 examples of the meta part of a content.opf file, before and after editing with your program I changed only the yellow line but 2 other things happened: the subject line was added (red), empty, and the light blue part was deleted.

So 3 questions:

Von: Ben @.> Gesendet: Montag, 31. Oktober 2022 06:05 An: benchen71/epub-metadata-editor @.> Cc: docjc @.>; Author @.> Betreff: Re: [benchen71/epub-metadata-editor] Bug(?) empty subject meta data (Issue #75)

I guess it should be possible. But there are a few different scenarios to consider (for example, that there has been a subject but the user has cleared that box). And I don't have as much programming time as I used to!

— Reply to this email directly, view it on GitHub https://github.com/benchen71/epub-metadata-editor/issues/75#issuecomment-1296546388 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ35T7PJUJOAA4KECNOSAUTWF5HOJANCNFSM6AAAAAARSHCYAY . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AZ35T7N4YOS47A6ZSAX4S4TWF5HOJA5CNFSM6AAAAAARSHCYA2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSNI65FI.gif Message ID: @. @.> >

benchen71 commented 2 years ago

If you want to add images, you have to do it directly on the GitHub site. I would like to see the images, though. If there is a bug, I will endeavour to fix it.

docjc commented 2 years ago

Hi, here the Pdf EME.pdf

benchen71 commented 2 years ago

You will need to attach the EPUB file. You can do it here, but you will need to change the extension from EPUB to JPG first. (I will change it back after downloading it.)

docjc commented 2 years ago

Hi, here is the test.jpg as requested

docjc commented 2 years ago

I forget to mention, test.jpg is untouched

benchen71 commented 2 years ago

I've downloaded the file (and edited the comment to remove it).

benchen71 commented 1 year ago

Thanks for your patience. I've made a small change to the subject creation code, so that an empty subject field won't be added. Hopefully, that solves the problem. That said, your screenshots show that the description was getting deleted. That looks like a serious bug; but I was not able to replicate it with the most recent version of the program. If you find something like that happening, please add another issue (including EPUB files changed to JPGs).

docjc commented 1 year ago

nice to hear from you..... (I know how difficult it is sometimes to have a hobby besides work and family - so don't worry.) I will test the new version and come back Thank you