Using JSON for script arguments - Githubissues

benchflow / data-transformers

Spark scripts utilised to transform data to the BenchFlow internal formats

Other

0 stars 0 forks source link

Using JSON for script arguments #66

Closed Cerfoglg closed 8 years ago

Cerfoglg commented 8 years ago

Fixes #67

[x] General Comment
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 1

See the complete overview on Codacy

<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Map the issues as well, as usual
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 1
- Added 2

See the complete overview on Codacy

<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme fixes #67
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> @Cerfoglg fine, just solve the remaining issues reported by Codacy
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> @Cerfoglg remaining: https://www.codacy.com/app/BenchFlow/data-transformers/pullRequest?prid=244584
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme Done
[x] File: data-transformers/transformers/propertiesTransformer.py:L223-238
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Issue found: Unused variable 'SUTName'
[x] File: data-transformers/transformers/statsTransformer.py:L5-12
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Issue found: Reimport 'json' (imported line 2)

VincenzoFerme commented 8 years ago

Map the issues as well, as usual

Cerfoglg commented 8 years ago

@VincenzoFerme fixes #67

VincenzoFerme commented 8 years ago

@Cerfoglg fine, just solve the remaining issues reported by Codacy

VincenzoFerme commented 8 years ago

@Cerfoglg remaining: https://www.codacy.com/app/BenchFlow/data-transformers/pullRequest?prid=244584

Cerfoglg commented 8 years ago

@VincenzoFerme Done