Faban transformer added

Cerfoglg commented 8 years ago

Related to #52

[x] Fix https://www.codacy.com/app/BenchFlow/data-transformers/pullRequest?prid=249622
[x] You don't need to perform a find each time, just do once for each type of data you need, then access it. E.g., in https://github.com/benchflow/data-transformers/pull/68/files#diff-f378a6609614365d2cc18cb7277f5075R20, but you also do the same in other part of the code
[x] Minio operations should be in common: https://github.com/benchflow/data-transformers/pull/68/files#diff-f378a6609614365d2cc18cb7277f5075R156
[x] Remove lines with local paths, e.g. https://github.com/benchflow/data-transformers/pull/68/files#diff-f378a6609614365d2cc18cb7277f5075R206
[x] File: data-transformers/transformers/fabanTransformer.py:L1-286
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> If you continues, you miss the next operation. Are you sure it is the expected behaviour?
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme Yes, because I don't want the "passed" field to be recorded as a generic stat, since it's always there.
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> I don't get how you can execute the next two lines if you have a continue here
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> I don't want to in fact, I want to skip the passed field, because it's not a numerical stat. I'll write this more clearly by putting the check at the top.
[x] File: data-transformers/transformers/fabanTransformer.py:L1-286
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> You are missing the <target> entity: https://github.com/benchflow/analysers/issues/70#issuecomment-221501351
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme Sorry, forgot. Adding it
[x] File: data-transformers/transformers/fabanTransformer.py:L1-286
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Why from index 2 and not 1?
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme That header line looks like this: Time (s) MyOperation1 MyOperation2 second element is the (s), so to record the op names I gotta start from 2.
[x] File: data-transformers/transformers/fabanTransformer.py:L1-286
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> Where do you store the unit of measure of the timing, that is reported next to the word Time in the first column?
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme I don't. I'll add and store that too then.
[x] File: data-transformers/transformers/fabanTransformer.py:L1-286
<img border=0 src='https://avatars.githubusercontent.com/u/7163641?v=3' height=16 width=16'> This check is equal to the one at line https://github.com/benchflow/data-transformers/pull/68/files#diff-f378a6609614365d2cc18cb7277f5075R210. Place it in a method.
[x] General Comment
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme All ready
<img border=0 src='https://avatars.githubusercontent.com/u/8819678?v=3' height=16 width=16'> @VincenzoFerme Everything done now

Cerfoglg commented 8 years ago

@VincenzoFerme All ready

Cerfoglg commented 8 years ago

@VincenzoFerme Everything done now

VincenzoFerme commented 8 years ago

:+1:

benchflow / data-transformers

Faban transformer added #68