search

benchmark-action / github-action-benchmark

GitHub Action for continuous benchmarking to keep performance
https://benchmark-action.github.io/github-action-benchmark/dev/bench/
MIT License
1.02k stars 152 forks source link

For dotnet benchmarking the unit is currently hardcoded to nanosecond. Can it be derived from the json like for other benchmarks? #238

Open lavakarthura opened 7 months ago

lavakarthura commented 7 months ago

We are using this tool to report our Dotnet Benchmarks but the default "nano second" unit is not very intuitive. Also we want to add custom columns which can report throughput in unit like "GBps" etc. Both are not feasible because it appears the unit is hardcoded to "ns" - https://github.com/benchmark-action/github-action-benchmark/blob/master/src/extract.ts#L656

ktrz commented 7 months ago

Hi @lavakarthura

Thank you for filing this issue. We are using the json exported file and I could not find any reference to the unit there. This is the output we are using

If possible, please provide an example benchmark or its output so I can use it for testing.