Open jaqx0r opened 6 months ago
There's a further bug here -- the name BenchmarkStore/Add
loses the test name suffix. It looks like the benchmark-action is incorrectly assuming the suffix -1 is the number of procs, but go test -bench
does not append a suffix for the default 1 CPU option.
So I don't think this attempt at parsing out N procs
here is a useful function and should be removed. I'll offer a PR if you agree.
https://github.com/google/mtail/actions/runs/8951254978?pr=858
The table includes lines like
BenchmarkStore/Add 818.6 ns/op 821.1 ns/op 1.00 BenchmarkStore/Add-1 778.3 ns/op 780.2 ns/op 1.00 BenchmarkStore/Add-1 779.9 ns/op 780.2 ns/op 1.00
which is confusng because these are three different scenarios -- the number of procs per the -cpu flag to
go test -bench
.This is being recorded in the JSON file found in https://github.com/google/mtail/actions/runs/8951254978/job/24587370213?pr=858
in this
extra
field. It would be useful if the name column included the "N procs" part as well to differentiate the names. Or it would be fine to leave the name alone asBenchmarkStore/Add-1-4
and not extract the procs count into a special "extra"