ENH refactor the way normalization is being applied to the datasets

benchopt / benchmark_resnet_classif

Benchopt benchmark for ResNet fitting on a classification task

https://benchopt.github.io/results/benchmark_resnet_classif.html

8 stars 4 forks source link

ENH refactor the way normalization is being applied to the datasets #24

Open zaccharieramzi opened 2 years ago

zaccharieramzi commented 2 years ago

Currently, there is a lot of copy-pasting that was introduced by https://github.com/benchopt/benchmark_resnet_classif/pull/19 when it comes to handling the normalization.

Basically, we want to have the same normalization for all datasets, but not apply it at the same times. In particular, we want to be able to apply it after data augmentation in the case of the training set when fitting the model.

tomMoral commented 2 years ago

yeah I agree that would be nice to refactor, right now we are applying the normalisation in three different places.