search

benchttp / engine

Benchttp library in Go to run performance tests on HTTP endpoints.
Other
4 stars 1 forks source link

refactor: extract server app #51

Closed GregoryAlbouy closed 2 years ago

GregoryAlbouy commented 2 years ago

Description

Changes

Notes

codecov-commenter commented 2 years ago

Codecov Report

Merging #51 (30b13d8) into main (3118c70) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #51   +/-   ##
=======================================
  Coverage   73.88%   73.88%           
=======================================
  Files          28       28           
  Lines         873      873           
=======================================
  Hits          645      645           
  Misses        203      203           
  Partials       25       25
Flag Coverage Δ
unittests 73.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

GregoryAlbouy commented 2 years ago

Would you go down the road of embedding engine into desktop and calling the client via server there ?

I stopped here wondering what would be the next step. I opened the PR anyway for visibility & discuss the changes but I'm not even sure any of these has to be merged here.

How about moving the source code for server (i.e. cmd + httpclient + modules stuff) to desktop in src-server (alongside src and src-tauri) for instance?

moreirathomas commented 2 years ago

How about moving the source code for server (i.e. cmd + httpclient + modules stuff) to desktop in src-server (alongside src and src-tauri) for instance?

This may be the way to go, we are vendoring anyway.

For now I suggest that in the scope of this pr httpclient and server stay inside engine.

And then we can work on the changes on desktop. What do you think?

GregoryAlbouy commented 2 years ago

Let's merge the PR as an improvement step then, but we definitely need to get server out of here so this engine lib remains truly agnostic of its consumers (e.g. gh action dispatch to desktop really shouldn't be here)

moreirathomas commented 2 years ago

Totally agree given the direction we're going in. Small step is fine :)