bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.78k stars 1.32k forks source link

.gitattributes corrupt png and videos files after push #136

Closed ghost closed 5 years ago

ghost commented 5 years ago

Hello,

Do you know why the .gitattributes file make all the png and videos files not "readable" / "corrupt" after pushing to my bitbucket ?

Thx

chrisvfritz commented 5 years ago

I have not encountered any issue myself. What part of .gitattattributes seems to be causing the problem for you?

ghost commented 5 years ago

After searching on stackoverflow (https://stackoverflow.com/questions/19411981/images-corrupt-after-git-push) I found someone who was talking about the same problem.

"Given 8950 4e47 0d0a 1a... vs 8950 4e47 0a1a it's immediately obvious (well... :-) ) that something thought this was a text file and turned CR-LF (0d0a) into LF-only (0a). Are you (or they) using the core.eol attribute and/or other git attributes to manage end-of-line normalization?"

I just deleted the file and it worked again. I'm not a pro but it's seem to be eol=lf

It's my second projet with your boilerplate but the first time i'm using png and video. Svg is not affected.

ghost commented 5 years ago

After some new fresh install I got the same problem.

chrisvfritz commented 5 years ago

@Xationch Does this change help?

ghost commented 5 years ago

@chrisvfritz Yes it's all good. Images and videos are no longer corrupted now.