bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.77k stars 1.32k forks source link

Is `@vue/eslint-config-prettier` required ? #148

Closed peterhpchen closed 5 years ago

peterhpchen commented 5 years ago

There are two points that makes me confused:

  1. @vue/eslint-config-prettier is installed in devDependencies , but the boilerplate didn’t use the config of the @vue/eslint-config-prettier in the .eslintrc.js:
module.exports = {
  ...
  extends: [
    ...
    // @vue/eslint-config-prettier setting
    // '@vue/prettier',

    // eslint-config-prettier setting
    'prettier',
    'prettier/standard',
    'prettier/vue',
    ...
  ],
  ...
}

The boilerplate use eslint-config-prettier config instead of @vue/eslint-config-prettier config.

  1. There are eslint-config-prettier, eslint-plugin-prettier and prettier installed in @vue/eslint-config-prettier, but it only use eslint-config-prettier and prettier.

Base on the above I think it should install eslint-config-prettier but uninstall @vue/eslint-config-prettier.

If there are any misunderstandings, please feel free to comment below.

Thank you.

chrisvfritz commented 5 years ago

I just removed prettier from package.json (it was there from when I previously had to specify a specific version of prettier to make use of a bugfix only available in a PR), so @vue/eslint-config-prettier is doing a little more now. Thanks for your attention to detail. 🙂