search

bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.78k stars 1.32k forks source link

Fix stylelint config: selector-class-pattern #41

Closed julijane closed 6 years ago

julijane commented 6 years ago

The provided stylelint selector-class-pattern does not accept class names with hyphens which can appear for example for transition css rules.

chrisvfritz commented 6 years ago

Yes, good point! 🙂

chrisvfritz commented 6 years ago

I wonder if it'd be better to selectively whitelist the Vue transition classes though, with something like:

/^[a-z][a-zA-Z]*(-(enter|leave)(-(active|to))?)?$/

What do you think?

julijane commented 6 years ago

I have no real opinion here, but I believe you have a point.

chrisvfritz commented 6 years ago

Yeah, I just don't want devs to start overusing the kebab-case pattern when the camelCase one will work better with CSS modules. Would you mind updating the PR? I don't have edit access.

julijane commented 6 years ago

Oops, I believe I can't do that because I have deleted my fork :/ I guess I have to close this PR and open a new one. Will check again and if necessary do that later.

chrisvfritz commented 6 years ago

I just added this. 🙂 Thanks!

julijane commented 6 years ago

Thanks, I just forgot. :)