search

bencodezen / vue-enterprise-boilerplate

An ever-evolving, very opinionated architecture and dev environment for new Vue SPA projects using Vue CLI.
7.78k stars 1.32k forks source link

yarn lint breaks _typography.scss #51

Closed apokokki closed 6 years ago

apokokki commented 6 years ago

"yarn lint" breaks _typography.scss file in windows 10 after clean install (tested with two machines).

yarn lint yarn run v1.7.0 $ eslint --ext .js,.vue --fix . && stylelint --fix "src//*.vue" "src/*/.scss" && markdownlint docs/.md .md && prettier --list-different --write "/*.{js,json,css,scss,vue,md}" src\design_typography.scss error Command failed with exit code 1.

stuta commented 6 years ago

I quess this is crlf vs lf problem.

stuta commented 6 years ago

Yarn lint works after changing line endings from crlf to lf.

Maybe adding file .gitattributes * text eol=lf would be good. Also changing in all windows gitconfig -files autocrlf = input helps.

chrisvfritz commented 6 years ago

I believe this should only be a problem with versions of Git prior to 2.10, but I just added a .gitattributes file to fix it in those older versions. Thanks @apokokki for the report and @stuta for the research. 🙂

apokokki commented 6 years ago

Thanks Chris - problem solved.